Skip to content

Content Moderator- Set language as a non-required field for Screen Text API #4240

Merged
dsgouda merged 7 commits intoAzure:psSdkJson6from
v-sodsou:LanguageUpdate
Apr 18, 2018
Merged

Content Moderator- Set language as a non-required field for Screen Text API #4240
dsgouda merged 7 commits intoAzure:psSdkJson6from
v-sodsou:LanguageUpdate

Conversation

@v-sodsou
Copy link
Copy Markdown
Contributor

@v-sodsou v-sodsou commented Apr 17, 2018 •
edited
Loading

Description

Azure/azure-rest-api-specs#2884

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Apr 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 file similar to this and regenerate the code.

Comment thread ...Services/dataPlane/Vision/ContentModerator/ContentModerator.Tests/Properties/AssemblyInfo.cs
[assembly: AssemblyVersion("0.11.0.0")]
[assembly: AssemblyFileVersion("0.11.0.0")]
[assembly: AssemblyVersion("0.12.0.0")]
[assembly: AssemblyFileVersion("0.12.0.0")]
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update the AssemblyVersion here

@v-sodsou
Copy link
Copy Markdown
Contributor Author

v-sodsou commented Apr 17, 2018 •
edited
Loading

@dsgouda
Regarding "Please create a generate.ps1 file similar to this and regenerate the code." I have already regenerated the code and committed the files changed along with metadata file(.txt file) which got generated when I ran generate.cmd command.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 17, 2018

I understand, we are slowly migrating towards using a generate.ps1 script instead of a cmd. You can do it later if you wish but we are eventually going to get there

@v-sodsou
Copy link
Copy Markdown
Contributor Author

v-sodsou commented Apr 17, 2018

@dsgouda
When I ran generateTool.ps1 , I see log file generated in metadata folder but not ps1 file in my sdk folder.
Could you provide the instructions on powershell script to be run.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 17, 2018

You need to create a generate.ps1 file similar to the one linked and put the proper relative paths and other args as in the example

@v-sodsou
Copy link
Copy Markdown
Contributor Author

v-sodsou commented Apr 17, 2018

@dsgouda

Hi , I have added the generate.ps1 file. could you please review it.

Thanks
Sonali Dsouza

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 17, 2018

@v-sodsou looks like the changes to package versions are no longer in the PR, please take a look

@v-sodsou
Copy link
Copy Markdown
Contributor Author

v-sodsou commented Apr 18, 2018

@dsgouda
I have added the version changes.Could you please review it.
Thanks
Sonali Dsouza

dsgouda
dsgouda approved these changes Apr 18, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to builds passing

@dsgouda dsgouda merged commit 6370ec2 into Azure:psSdkJson6 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-sodsou @dsgouda